Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1D50318A84 for ; Wed, 30 Sep 2015 03:40:08 +0000 (UTC) Received: (qmail 83670 invoked by uid 500); 30 Sep 2015 03:40:05 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 83628 invoked by uid 500); 30 Sep 2015 03:40:04 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 83617 invoked by uid 99); 30 Sep 2015 03:40:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Sep 2015 03:40:04 +0000 Date: Wed, 30 Sep 2015 03:40:04 +0000 (UTC) From: "Li Lu (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-4210) HBase reader throws NPE if Get returns no rows MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-4210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936328#comment-14936328 ] Li Lu commented on YARN-4210: ----------------------------- Yes, LGTM overall. My only reservation is about the logging message. > HBase reader throws NPE if Get returns no rows > ---------------------------------------------- > > Key: YARN-4210 > URL: https://issues.apache.org/jira/browse/YARN-4210 > Project: Hadoop YARN > Issue Type: Sub-task > Components: timelineserver > Affects Versions: YARN-2928 > Reporter: Varun Saxena > Assignee: Varun Saxena > Attachments: YARN-4210-YARN-2928.01.patch, YARN-4210-YARN-2928.02.patch, YARN-4210-YARN-2928.03.patch > > > If HBase Get does not fetch any rows for the query, we still try to parse the result and read fields. This leads to NPE while reading metrics. We should not attempt to read anything if no row is returned i.e. result is empty. > Found during web UI poc testing. > {noformat} > 2015-09-29 20:22:32,027 ERROR [95336304@qtp-1814206058-0] reader.TimelineReaderWebServices (TimelineReaderWebServices.java:handleException(199)) - Error while processing REST request > java.lang.NullPointerException > at org.apache.hadoop.yarn.server.timelineservice.storage.common.ColumnHelper.readResultsWithTimestamps(ColumnHelper.java:176) > at org.apache.hadoop.yarn.server.timelineservice.storage.flow.FlowRunColumnPrefix.readResultsWithTimestamps(FlowRunColumnPrefix.java:182) > at org.apache.hadoop.yarn.server.timelineservice.storage.TimelineEntityReader.readMetrics(TimelineEntityReader.java:212) > at org.apache.hadoop.yarn.server.timelineservice.storage.FlowRunEntityReader.parseEntity(FlowRunEntityReader.java:136) > at org.apache.hadoop.yarn.server.timelineservice.storage.TimelineEntityReader.readEntity(TimelineEntityReader.java:137) > at org.apache.hadoop.yarn.server.timelineservice.storage.HBaseTimelineReaderImpl.getEntity(HBaseTimelineReaderImpl.java:72) > at org.apache.hadoop.yarn.server.timelineservice.reader.TimelineReaderManager.getEntity(TimelineReaderManager.java:93) > at org.apache.hadoop.yarn.server.timelineservice.reader.TimelineReaderWebServices.getFlowRun(TimelineReaderWebServices.java:403) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)