Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C506F18495 for ; Tue, 15 Sep 2015 23:08:53 +0000 (UTC) Received: (qmail 1574 invoked by uid 500); 15 Sep 2015 23:08:47 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 1530 invoked by uid 500); 15 Sep 2015 23:08:47 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 1513 invoked by uid 99); 15 Sep 2015 23:08:47 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Sep 2015 23:08:47 +0000 Date: Tue, 15 Sep 2015 23:08:47 +0000 (UTC) From: "Hudson (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-4158) Remove duplicate close for LogWriter in AppLogAggregatorImpl#uploadLogsForContainers MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14746457#comment-14746457 ] Hudson commented on YARN-4158: ------------------------------ FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #391 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/391/]) YARN-4158. Remove duplicate close for LogWriter in AppLogAggregatorImpl#uploadLogsForContainers. Contributed by Zhihai Xu (jlowe: rev 8c1cdb17a03fec91bfab172fe92b67bdeb9ebfba) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/AppLogAggregatorImpl.java * hadoop-yarn-project/CHANGES.txt > Remove duplicate close for LogWriter in AppLogAggregatorImpl#uploadLogsForContainers > ------------------------------------------------------------------------------------ > > Key: YARN-4158 > URL: https://issues.apache.org/jira/browse/YARN-4158 > Project: Hadoop YARN > Issue Type: Improvement > Components: nodemanager > Affects Versions: 2.7.0 > Reporter: zhihai xu > Assignee: zhihai xu > Priority: Minor > Labels: cleanup > Fix For: 2.7.2 > > Attachments: YARN-4158.000.patch > > > Remove duplicate {{close}} for {{LogWriter}} in {{AppLogAggregatorImpl#uploadLogsForContainers}} > {{writer.close()}} was called twice in {{uploadLogsForContainers}}. One is called at the middle of the function and the other one is called at finally block. It will be better to just close {{writer}} once. Also {{LogWriter}} didn't implement java.io.Closeable interface. So we can't suppose {{LogWriter.close}} is idempotent. -- This message was sent by Atlassian JIRA (v6.3.4#6332)