hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "zhihai xu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4158) Remove duplicate close for LogWriter in AppLogAggregatorImpl#uploadLogsForContainers
Date Tue, 15 Sep 2015 20:32:46 GMT

    [ https://issues.apache.org/jira/browse/YARN-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14746107#comment-14746107
] 

zhihai xu commented on YARN-4158:
---------------------------------

Thanks [~jlowe] for reviewing and committing the patch!

> Remove duplicate close for LogWriter in AppLogAggregatorImpl#uploadLogsForContainers
> ------------------------------------------------------------------------------------
>
>                 Key: YARN-4158
>                 URL: https://issues.apache.org/jira/browse/YARN-4158
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: nodemanager
>    Affects Versions: 2.7.0
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>            Priority: Minor
>              Labels: cleanup
>             Fix For: 2.7.2
>
>         Attachments: YARN-4158.000.patch
>
>
> Remove duplicate {{close}} for {{LogWriter}} in {{AppLogAggregatorImpl#uploadLogsForContainers}}
> {{writer.close()}} was called twice in {{uploadLogsForContainers}}. One is called at
the middle of the function and the other one is called at finally block. It will be better
to just close {{writer}} once. Also {{LogWriter}} didn't implement java.io.Closeable interface.
So we can't suppose {{LogWriter.close}} is idempotent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message