hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Naganarasimha G R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4106) NodeLabels for NM in distributed mode is not updated even after clusterNodelabel addition in RM
Date Sat, 05 Sep 2015 01:50:46 GMT

    [ https://issues.apache.org/jira/browse/YARN-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14731697#comment-14731697
] 

Naganarasimha G R commented on YARN-4106:
-----------------------------------------

Thanks for the comments [~leftnoteasy],
bq. Does this mean we cannot get labels when initializing ConfigurationNodeLabelsProvider?
Actually {{timerTask.run();}} in {{serviceStart}} is responsible to fetch the labels for the
very first time. Reason for this modification is, if some class extends this in future and
forgets to set the labels during the start then it will be missed hence trying to take care
of this in AbstractProvider class itself and secondly we cannot  choose {{intervalTime to
0}} because there is configuration that timer task need not run at all, so timer itself will
not be created in this case, considering all this, he has modified as per the patch.
bq. Add a test for new behavior of this JIRA
Well for second issue  : i felt changes were related to the design level and scenarios are
the same. only thing we have missed is to check whether the timer is triggered after the configured
interval and the new labels are set, i think we can have one test case for this. Apart from
this were you referring to the test case for first issue also ?


> NodeLabels for NM in distributed mode is not updated even after clusterNodelabel addition
in RM 
> ------------------------------------------------------------------------------------------------
>
>                 Key: YARN-4106
>                 URL: https://issues.apache.org/jira/browse/YARN-4106
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>            Priority: Critical
>         Attachments: 0001-YARN-4106.patch, 0002-YARN-4106.patch, 0003-YARN-4106.patch,
0004-YARN-4106.patch
>
>
> NodeLabels for NM in distributed mode is not updated even after clusterNodelabel addition
in RM
> Steps to reproduce
> ===============
> # Configure nodelabel in distributed mode
> yarn.node-labels.configuration-type=distributed
> provider = config
> yarn.nodemanager.node-labels.provider.fetch-interval-ms=120000ms
> # Start RM the NM
> # Once NM is registration is done add nodelabels in RM
> Nodelabels not getting updated in RM side 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message