hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Naganarasimha G R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4078) getPendingResourceRequestForAttempt is present in AbstractYarnScheduler should be present in YarnScheduler interface instead
Date Tue, 15 Sep 2015 18:46:46 GMT

    [ https://issues.apache.org/jira/browse/YARN-4078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14745921#comment-14745921
] 

Naganarasimha G R commented on YARN-4078:
-----------------------------------------

[~jianhe], seems like test case failure is not related to the patch.

> getPendingResourceRequestForAttempt is present in AbstractYarnScheduler should be present
in YarnScheduler interface instead	
> -----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-4078
>                 URL: https://issues.apache.org/jira/browse/YARN-4078
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>            Priority: Minor
>         Attachments: YARN-4078.20150915-2.patch, YARN-4078.20150915.patch
>
>
> Currently getPendingResourceRequestForAttempt is present in {{AbstractYarnScheduler}}.
> *But in AppInfo,  we are calling this method by typecasting it to AbstractYarnScheduler,
which is incorrect.*
> Because if a custom scheduler is to be added, it will implement YarnScheduler, not AbstractYarnScheduler.
> This method should be moved to YarnScheduler or it should have a guarded check like in
other places (RMAppAttemptBlock.getBlackListedNodes) 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message