hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Li Lu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4075) [reader REST API] implement support for querying for flows and flow runs
Date Mon, 21 Sep 2015 22:31:04 GMT

    [ https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901537#comment-14901537
] 

Li Lu commented on YARN-4075:
-----------------------------

Hi [~varun_saxena]! Thanks for the work and sorry for the delayed reply. I looked at your
POC.2 patch and here are some comments:

- getFlows (/flows/{clusterId}): Maybe we'd like to return the "default" cluster, or the cluster
the reader runs on (or a reader farm associates to), if the given clusterId is empty?
- In TestTimelineReaderWebServicesFlowRun#testGetFlowRun, why do we compare equality through
toString and comparing two strings? I think we need a "deep comparison" method for timeline
metrics for this case, so maybe you'd like to add this method, and use it in testGetFlowRun?

- The following logic:
{code}
+          callerUGI != null && (userId == null || userId.isEmpty()) ?
+          callerUGI.getUserName().trim() : parseStr(userId)
{code}
is common enough in TimelineReaderWebServices. Since the logic is not quite trivial, maybe
we'd like to put them in a standalong private method? 
- I just noticed that we're returning Set<TimelineEntity> rather than TimelineEntities
in timeline reader. This is not consistent with timeline writer (which uses TimelineEntities).
It doesn't hurt much to have one more level of indirection, so maybe we'd like to change the
readers to return TimelineEntities? In this way the reader and the writer will have the same
behavior on this. 
- Any special reasons to refactor TestHBaseTimelineStorage? 

Since we're merging YARN-4074 soon, I have not checked if this patch applies to the latest
YARN-2928 branch. We need to make sure that after you refreshed your patch. 

> [reader REST API] implement support for querying for flows and flow runs
> ------------------------------------------------------------------------
>
>                 Key: YARN-4075
>                 URL: https://issues.apache.org/jira/browse/YARN-4075
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Sangjin Lee
>            Assignee: Varun Saxena
>         Attachments: YARN-4075-YARN-2928.POC.1.patch, YARN-4075-YARN-2928.POC.2.patch
>
>
> We need to be able to query for flows and flow runs via REST.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message