hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuan Gong (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1897) CLI and core support for signal container functionality
Date Thu, 24 Sep 2015 00:32:04 GMT

    [ https://issues.apache.org/jira/browse/YARN-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14905571#comment-14905571
] 

Xuan Gong commented on YARN-1897:
---------------------------------

Thanks for the patch. [~mingma], and thanks for the review, [~djp]
The patch looks good overall. Several minor comments:
* Can we add diagnosis in SignalContainerRequest ? We could add the reasons why the signal
is sent, such as "Killed by RM", "Killed by the Users". Also, in future, we might need to
sync up the flows for signal container, container preemption, etc.
* add all signal_command that we current support in SIGNAL_CMD description
* let us not parse containerId like this
{code}
final String containerId = signalArgs[0];
{code}
Take a look at the combination of MOVE_TO_QUEUE_CMD and QUEUE_CMD

Let us try to at least finalize the public API for this feature. 
[~stevel@apache.org], any comments ?

> CLI and core support for signal container functionality
> -------------------------------------------------------
>
>                 Key: YARN-1897
>                 URL: https://issues.apache.org/jira/browse/YARN-1897
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api
>            Reporter: Ming Ma
>            Assignee: Ming Ma
>         Attachments: YARN-1897-2.patch, YARN-1897-3.patch, YARN-1897-4.patch, YARN-1897-5.patch,
YARN-1897-6.patch, YARN-1897-7.patch, YARN-1897.1.patch
>
>
> We need to define SignalContainerRequest and SignalContainerResponse first as they are
needed by other sub tasks. SignalContainerRequest should use OS-independent commands and provide
a way to application to specify "reason" for diagnosis. SignalContainerResponse might be empty.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message