Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4DE1718480 for ; Tue, 25 Aug 2015 06:44:46 +0000 (UTC) Received: (qmail 88344 invoked by uid 500); 25 Aug 2015 06:44:46 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 88296 invoked by uid 500); 25 Aug 2015 06:44:46 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 88282 invoked by uid 99); 25 Aug 2015 06:44:46 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Aug 2015 06:44:46 +0000 Date: Tue, 25 Aug 2015 06:44:46 +0000 (UTC) From: "Varun Saxena (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-4078) Unchecked typecast to AbstractYarnScheduler in AppInfo MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-4078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710703#comment-14710703 ] Varun Saxena commented on YARN-4078: ------------------------------------ In the main code, its guarded at places other than the issue raised here. > Unchecked typecast to AbstractYarnScheduler in AppInfo > ------------------------------------------------------ > > Key: YARN-4078 > URL: https://issues.apache.org/jira/browse/YARN-4078 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager > Reporter: Naganarasimha G R > Assignee: Naganarasimha G R > Priority: Minor > > Currently getPendingResourceRequestForAttempt is present in {{AbstractYarnScheduler}}. > *But in AppInfo, we are calling this method by typecasting it to AbstractYarnScheduler, which is incorrect.* > Because if a custom scheduler is to be added, it will implement YarnScheduler, not AbstractYarnScheduler. > This method should be moved to YarnScheduler or it should have a guarded check like in other places (RMAppAttemptBlock.getBlackListedNodes) -- This message was sent by Atlassian JIRA (v6.3.4#6332)