Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0D09118C37 for ; Sat, 22 Aug 2015 00:43:47 +0000 (UTC) Received: (qmail 32426 invoked by uid 500); 22 Aug 2015 00:43:46 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 32379 invoked by uid 500); 22 Aug 2015 00:43:46 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 32365 invoked by uid 99); 22 Aug 2015 00:43:46 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 22 Aug 2015 00:43:46 +0000 Date: Sat, 22 Aug 2015 00:43:46 +0000 (UTC) From: "Naganarasimha G R (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-4058) Miscellaneous issues in NodeManager project MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-4058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14707703#comment-14707703 ] Naganarasimha G R commented on YARN-4058: ----------------------------------------- thanks [~sjlee0] for the review comments, The reason for raising the application creation issue here was, the impact is more with our case as we are creating TimelineClient as part of application creation and further we might introduce some thread pools and queues inside TimelineClient for putAsync and other was a small issue with unused variable hence clubbed with other issues in this jira, if required i can segregate it. Thoughts? > Miscellaneous issues in NodeManager project > ------------------------------------------- > > Key: YARN-4058 > URL: https://issues.apache.org/jira/browse/YARN-4058 > Project: Hadoop YARN > Issue Type: Sub-task > Components: timelineserver > Reporter: Naganarasimha G R > Assignee: Naganarasimha G R > Priority: Minor > Attachments: YARN-4058.YARN-2928.001.patch > > > # TestSystemMetricsPublisherForV2.testPublishApplicationMetrics is failing > # Unused ApplicationACLsManager in ContainerManagerImpl > # In ContainerManagerImpl.startContainerInternal ApplicationImpl instance is created and then checked whether it exists in context.getApplications(). everytime ApplicationImpl is created state machine is intialized and TimelineClient is created which is required only if added to the context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)