Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 41A881800C for ; Fri, 21 Aug 2015 05:52:47 +0000 (UTC) Received: (qmail 59541 invoked by uid 500); 21 Aug 2015 05:52:47 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 59488 invoked by uid 500); 21 Aug 2015 05:52:47 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 59463 invoked by uid 99); 21 Aug 2015 05:52:46 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Aug 2015 05:52:46 +0000 Date: Fri, 21 Aug 2015 05:52:46 +0000 (UTC) From: "Hudson (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-3986) getTransferredContainers in AbstractYarnScheduler should be present in YarnScheduler interface instead MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-3986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14706264#comment-14706264 ] Hudson commented on YARN-3986: ------------------------------ FAILURE: Integrated in Hadoop-trunk-Commit #8334 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/8334/]) YARN-3986. getTransferredContainers in AbstractYarnScheduler should be present in YarnScheduler interface (rohithsharmaks: rev 22de7c1dca1be63d523de833163ae51bfe638a79) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ApplicationMasterService.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestWorkPreservingRMRestart.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/YarnScheduler.java * hadoop-yarn-project/CHANGES.txt > getTransferredContainers in AbstractYarnScheduler should be present in YarnScheduler interface instead > ------------------------------------------------------------------------------------------------------ > > Key: YARN-3986 > URL: https://issues.apache.org/jira/browse/YARN-3986 > Project: Hadoop YARN > Issue Type: Bug > Components: scheduler > Affects Versions: 2.7.0 > Reporter: Varun Saxena > Assignee: Varun Saxena > Fix For: 2.8.0 > > Attachments: YARN-3986.01.patch, YARN-3986.02.patch, YARN-3986.03.patch > > > Currently getTransferredContainers is present in {{AbstractYarnScheduler}}. > *But in ApplicationMasterService, while registering AM, we are calling this method by typecasting it to AbstractYarnScheduler, which is incorrect.* > This method should be moved to YarnScheduler. > Because if a custom scheduler is to be added, it will implement YarnScheduler, not AbstractYarnScheduler. > As ApplicationMasterService is calling getTransferredContainers by typecasting it to AbstractYarnScheduler, it is imposing an indirect dependency on AbstractYarnScheduler for any pluggable custom scheduler. > We can move the method to YarnScheduler and leave the definition in AbstractYarnScheduler as it is. -- This message was sent by Atlassian JIRA (v6.3.4#6332)