hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sangjin Lee (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (YARN-4025) Deal with byte representations of Longs in writer code
Date Thu, 13 Aug 2015 03:27:46 GMT

     [ https://issues.apache.org/jira/browse/YARN-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sangjin Lee updated YARN-4025:
------------------------------
    Attachment: YARN-4025-YARN-2928.002.patch

v.2 patch posted.

- reconciled with YARN-3906 (application table)
- updated how {{HBaseTimelineReaderImpl}} reads events
- made {{TestHBaseTimelineWriterImpl}} verify the results from reading timeline entities using
{{HBaseTimelineReaderImpl}} in addition to direct verification using the HBase schema
- simplified some asserts in the test
- fixed a bug in {{HBaseTimelineReaderImpl}} on reading config

One major change I did is that now {{TestHBaseTimelineWriterImpl}} verifies the timeline entities
read by {{HBaseTimelineReaderImpl}} as well. This provides a nice benefit of verifying correctness
of {{HBaseTimelineReaderImpl}}. It uncovered a bug in the process. :)

> Deal with byte representations of Longs in writer code
> ------------------------------------------------------
>
>                 Key: YARN-4025
>                 URL: https://issues.apache.org/jira/browse/YARN-4025
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Vrushali C
>            Assignee: Sangjin Lee
>         Attachments: YARN-4025-YARN-2928.001.patch, YARN-4025-YARN-2928.002.patch
>
>
> Timestamps are being stored as Longs in hbase by the HBaseTimelineWriterImpl code. There
seem to be some places in the code where there are conversions between Long to byte[] to String
for easier argument passing between function calls. Then these values end up being converted
back to byte[] while storing in hbase. 
> It would be better to pass around byte[] or the Longs themselves  as applicable. 
> This may result in some api changes (store function) as well in adding a few more function
calls like getColumnQualifier which accepts a pre-encoded byte array. It will be in addition
to the existing api which accepts a String and the ColumnHelper to return a byte[] column
name instead of a String one. 
> Filing jira to track these changes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message