Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AC8071878F for ; Tue, 28 Jul 2015 19:04:19 +0000 (UTC) Received: (qmail 45601 invoked by uid 500); 28 Jul 2015 19:04:06 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 45551 invoked by uid 500); 28 Jul 2015 19:04:06 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 45285 invoked by uid 99); 28 Jul 2015 19:04:06 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Jul 2015 19:04:06 +0000 Date: Tue, 28 Jul 2015 19:04:06 +0000 (UTC) From: "Allen Wittenauer (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-3988) DockerContainerExecutor should allow user specify "docker run" parameters MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-3988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14644863#comment-14644863 ] Allen Wittenauer commented on YARN-3988: ---------------------------------------- It's a bit of a security hole to let users dictate docker run params.... > DockerContainerExecutor should allow user specify "docker run" parameters > ------------------------------------------------------------------------- > > Key: YARN-3988 > URL: https://issues.apache.org/jira/browse/YARN-3988 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager > Affects Versions: 2.7.1 > Reporter: Chen He > Assignee: Chen He > > In current DockerContainerExecutor, the "docker run" command has fixed parameters: > String commandStr = commands.append(dockerExecutor) > .append(" ") > .append("run") > .append(" ") > .append("--rm --net=host") > .append(" ") > .append(" --name " + containerIdStr) > .append(localDirMount) > .append(logDirMount) > .append(containerWorkDirMount) > .append(" ") > .append(containerImageName) > .toString(); > For example, it is not flexible if users want to start a docker container with attaching extra volume(s) and other "docker run" parameters. -- This message was sent by Atlassian JIRA (v6.3.4#6332)