Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CA46F18A6C for ; Mon, 13 Jul 2015 20:46:06 +0000 (UTC) Received: (qmail 7390 invoked by uid 500); 13 Jul 2015 20:46:06 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 7344 invoked by uid 500); 13 Jul 2015 20:46:06 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 7327 invoked by uid 99); 13 Jul 2015 20:46:06 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Jul 2015 20:46:06 +0000 Date: Mon, 13 Jul 2015 20:46:06 +0000 (UTC) From: "Wangda Tan (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-3885) ProportionalCapacityPreemptionPolicy doesn't preempt if queue is more than 2 level MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625302#comment-14625302 ] Wangda Tan commented on YARN-3885: ---------------------------------- Increase to blocker since this is a bad bug. Thanks for working on this [~ajithshetty]. I think patch looks generally good except one thing also mentioned by [~xinxianyin]: bq. for non-leaf queues, min(sum of children's PREEMOTABLEs, extra) -----(this is what CHILDRENPREEMPTABLE does in the patch) Specifying {{ret.preemptableExtra = childrensPreemptable;}} seems not enough. Could you add a test to verify: when sum(queue.children.preemptable) > extra, we can still get correct preemption result? > ProportionalCapacityPreemptionPolicy doesn't preempt if queue is more than 2 level > ---------------------------------------------------------------------------------- > > Key: YARN-3885 > URL: https://issues.apache.org/jira/browse/YARN-3885 > Project: Hadoop YARN > Issue Type: Bug > Components: yarn > Affects Versions: 2.8.0 > Reporter: Ajith S > Assignee: Ajith S > Priority: Blocker > Attachments: YARN-3885.02.patch, YARN-3885.03.patch, YARN-3885.04.patch, YARN-3885.patch > > > when preemption policy is {{ProportionalCapacityPreemptionPolicy.cloneQueues}} > this piece of code, to calculate {{untoucable}} doesnt consider al the children, it considers only immediate childern -- This message was sent by Atlassian JIRA (v6.3.4#6332)