Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5C91E18F37 for ; Thu, 23 Jul 2015 23:47:05 +0000 (UTC) Received: (qmail 69289 invoked by uid 500); 23 Jul 2015 23:47:05 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 69237 invoked by uid 500); 23 Jul 2015 23:47:05 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 69224 invoked by uid 99); 23 Jul 2015 23:47:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Jul 2015 23:47:05 +0000 Date: Thu, 23 Jul 2015 23:47:05 +0000 (UTC) From: "Jian He (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-3867) ContainerImpl changes to support container resizing MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-3867?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D14639= 682#comment-14639682 ]=20 Jian He commented on YARN-3867: ------------------------------- thanks [~mding], some comments on the patch: - CHANGE_CONTAINER_RESOURCE/ChangeContainerResourceTransition: how about se= nding the changeEvent directly into ContainerMonitorImpl from ContainerMana= gerImpl? this saves one hop of event and transition through the ContainerIm= pl - ChangeMonitoringContainerResourceEvent: how about just passing in the Res= ource object and move the vmem/pmem re-size specific logic into containerMo= nitorImpl ? - we may use volatile keyword for this.resource ? {code} this.readLock.lock();=E2=80=A8try {=E2=80=A8 return Resource.newInstance(t= his.resource.getMemory(),=E2=80=A8 this.resource.getVirtualCores());= =E2=80=A8} finally {=E2=80=A8 this.readLock.unlock();=E2=80=A8} {code} > ContainerImpl changes to support container resizing > --------------------------------------------------- > > Key: YARN-3867 > URL: https://issues.apache.org/jira/browse/YARN-3867 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager > Reporter: MENG DING > Assignee: MENG DING > Attachments: YARN-3867-YARN-1197.3.patch, YARN-3867.1.patch, YARN= -3867.2.patch > > > 1) ContainerImpl logic changes in NM to handle events related to containe= r resizing > 2) Relevant test cases -- This message was sent by Atlassian JIRA (v6.3.4#6332)