Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8B03B1882D for ; Thu, 9 Jul 2015 18:34:07 +0000 (UTC) Received: (qmail 30277 invoked by uid 500); 9 Jul 2015 18:34:07 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 30229 invoked by uid 500); 9 Jul 2015 18:34:07 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 30215 invoked by uid 99); 9 Jul 2015 18:34:07 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Jul 2015 18:34:07 +0000 Date: Thu, 9 Jul 2015 18:34:07 +0000 (UTC) From: "Sangjin Lee (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-3836) add equals and hashCode to TimelineEntity and other classes in the data model MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621033#comment-14621033 ] Sangjin Lee commented on YARN-3836: ----------------------------------- I take back my comment about the null check for {{getIdentifier()}}. Looking at it, I see that {{getIdentifier()}} will never return null. Sorry for the confusion. > add equals and hashCode to TimelineEntity and other classes in the data model > ----------------------------------------------------------------------------- > > Key: YARN-3836 > URL: https://issues.apache.org/jira/browse/YARN-3836 > Project: Hadoop YARN > Issue Type: Sub-task > Components: timelineserver > Affects Versions: YARN-2928 > Reporter: Sangjin Lee > Assignee: Li Lu > Attachments: YARN-3836-YARN-2928.001.patch, YARN-3836-YARN-2928.002.patch > > > Classes in the data model API (e.g. {{TimelineEntity}}, {{TimelineEntity.Identifer}}, etc.) do not override {{equals()}} or {{hashCode()}}. This can cause problems when these objects are used in a collection such as a {{HashSet}}. We should implement these methods wherever appropriate. -- This message was sent by Atlassian JIRA (v6.3.4#6332)