Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Wed, 1 Jul 2015 11:29:05 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12839057.1434693834000.69723.1435750145686@Atlassian.JIRA>
In-Reply-To: <JIRA.12839057.1434693834000@Atlassian.JIRA>
References: <JIRA.12839057.1434693834000@Atlassian.JIRA>
 <JIRA.12839057.1434693834080@arcas>
Subject: [jira] [Commented] (YARN-3830)
 AbstractYarnScheduler.createReleaseCache may try to clean a null attempt
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609965#comment-14609965 ] 

Hadoop QA commented on YARN-3830:
---------------------------------

\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  15m 47s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to include 1 new or modified test files. |
| {color:green}+1{color} | javac |   7m 34s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 34s | There were no new javadoc warning messages. |
| {color:green}+1{color} | release audit |   0m 23s | The applied patch does not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   0m 45s | There were no new checkstyle issues. |
| {color:green}+1{color} | whitespace |   0m  1s | The patch has no lines that end in whitespace. |
| {color:green}+1{color} | install |   1m 36s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   1m 26s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests |  50m 56s | Tests passed in hadoop-yarn-server-resourcemanager. |
| | |  88m 38s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12743024/YARN-3830_4.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 7405c59 |
| hadoop-yarn-server-resourcemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/8403/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt |
| Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/8403/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/8403/console |


This message was automatically generated.

> AbstractYarnScheduler.createReleaseCache may try to clean a null attempt
> ------------------------------------------------------------------------
>
>                 Key: YARN-3830
>                 URL: https://issues.apache.org/jira/browse/YARN-3830
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: scheduler
>            Reporter: nijel
>            Assignee: nijel
>         Attachments: YARN-3830_1.patch, YARN-3830_2.patch, YARN-3830_3.patch, YARN-3830_4.patch
>
>
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.AbstractYarnScheduler.createReleaseCache()
> {code}
> protected void createReleaseCache() {
>     // Cleanup the cache after nm expire interval.
>     new Timer().schedule(new TimerTask() {
>       @Override
>       public void run() {
>         for (SchedulerApplication<T> app : applications.values()) {
>           T attempt = app.getCurrentAppAttempt();
>           synchronized (attempt) {
>             for (ContainerId containerId : attempt.getPendingRelease()) {
>               RMAuditLogger.logFailure(
> {code}
> Here the attempt can be null since the attempt is created later. So null pointer exception  will come
> {code}
> 2015-06-19 09:29:16,195 | ERROR | Timer-3 | Thread Thread[Timer-3,5,main] threw an Exception. | YarnUncaughtExceptionHandler.java:68
> java.lang.NullPointerException
> 	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.AbstractYarnScheduler$1.run(AbstractYarnScheduler.java:457)
> 	at java.util.TimerThread.mainLoop(Timer.java:555)
> 	at java.util.TimerThread.run(Timer.java:505)
> {code}
> This will skip the other applications in this run.
> Can add a null check and continue with other applications


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)