Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B07DA18DBE for ; Wed, 8 Jul 2015 23:08:05 +0000 (UTC) Received: (qmail 17943 invoked by uid 500); 8 Jul 2015 23:08:05 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 17899 invoked by uid 500); 8 Jul 2015 23:08:05 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 17888 invoked by uid 99); 8 Jul 2015 23:08:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Jul 2015 23:08:05 +0000 Date: Wed, 8 Jul 2015 23:08:05 +0000 (UTC) From: "Carlo Curino (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-3800) Simplify inmemory state for ReservationAllocation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-3800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619550#comment-14619550 ] Carlo Curino commented on YARN-3800: ------------------------------------ Patch generally looks good, and I spoke with [~subru] that explained me why you are making these changes, and overall makes sense. A couple nits and then I am ok to commit this: 1) I think it is nicer to have types in HashMap<> and TreeMap<> initializations. 2) In other places you did this change already, but in TestRLESparseResourceAllocation you have a generateAllocation that still produces ReservationRequests and then you immediately convert to Resource. Probably easier to change generateAllocation Thanks for the work on this patch. > Simplify inmemory state for ReservationAllocation > ------------------------------------------------- > > Key: YARN-3800 > URL: https://issues.apache.org/jira/browse/YARN-3800 > Project: Hadoop YARN > Issue Type: Sub-task > Components: capacityscheduler, fairscheduler, resourcemanager > Reporter: Anubhav Dhoot > Assignee: Anubhav Dhoot > Attachments: YARN-3800.001.patch, YARN-3800.002.patch, YARN-3800.002.patch, YARN-3800.003.patch, YARN-3800.004.patch > > > Instead of storing the ReservationRequest we store the Resource for allocations, as thats the only thing we need. Ultimately we convert everything to resources anyway -- This message was sent by Atlassian JIRA (v6.3.4#6332)