Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F406B17EE9 for ; Tue, 14 Jul 2015 14:36:05 +0000 (UTC) Received: (qmail 48882 invoked by uid 500); 14 Jul 2015 14:36:05 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 48842 invoked by uid 500); 14 Jul 2015 14:36:05 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 48829 invoked by uid 99); 14 Jul 2015 14:36:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Jul 2015 14:36:05 +0000 Date: Tue, 14 Jul 2015 14:36:05 +0000 (UTC) From: "Hudson (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-3453) Fair Scheduler: Parts of preemption logic uses DefaultResourceCalculator even in DRF mode causing thrashing MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-3453?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D14626= 400#comment-14626400 ]=20 Hudson commented on YARN-3453: ------------------------------ FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #244 (See [https://builds.ap= ache.org/job/Hadoop-Hdfs-trunk-Java8/244/]) YARN-3453. Ensure preemption logic in FairScheduler uses DominantResourceCa= lculator in DRF queues to prevent unnecessary thrashing. (asuresh) (Arun Su= resh: rev ac94ba3e185115b83351e35c610c2b8ff91b1ebc) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-res= ourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/sc= heduler/fair/policies/DominantResourceFairnessPolicy.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-res= ourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/sc= heduler/fair/FairScheduler.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-res= ourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/sc= heduler/fair/TestFSLeafQueue.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-res= ourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/sc= heduler/fair/policies/FifoPolicy.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-res= ourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/sc= heduler/fair/SchedulingPolicy.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-res= ourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/sc= heduler/fair/FSLeafQueue.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-res= ourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/sc= heduler/fair/TestFairScheduler.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-res= ourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/sc= heduler/fair/policies/FairSharePolicy.java > Fair Scheduler: Parts of preemption logic uses DefaultResourceCalculator = even in DRF mode causing thrashing > -------------------------------------------------------------------------= ---------------------------------- > > Key: YARN-3453 > URL: https://issues.apache.org/jira/browse/YARN-3453 > Project: Hadoop YARN > Issue Type: Bug > Components: fairscheduler > Affects Versions: 2.6.0 > Reporter: Ashwin Shankar > Assignee: Arun Suresh > Attachments: YARN-3453.1.patch, YARN-3453.2.patch, YARN-3453.3.pa= tch, YARN-3453.4.patch, YARN-3453.5.patch > > > There are two places in preemption code flow where DefaultResourceCalcula= tor is used, even in DRF mode. > Which basically results in more resources getting preempted than needed, = and those extra preempted containers aren=E2=80=99t even getting to the =E2= =80=9Cstarved=E2=80=9D queue since scheduling logic is based on DRF's Calcu= lator. > Following are the two places : > 1. {code:title=3DFSLeafQueue.java|borderStyle=3Dsolid} > private boolean isStarved(Resource share) > {code} > A queue shouldn=E2=80=99t be marked as =E2=80=9Cstarved=E2=80=9D if the d= ominant resource usage > is >=3D fair/minshare. > 2. {code:title=3DFairScheduler.java|borderStyle=3Dsolid} > protected Resource resToPreempt(FSLeafQueue sched, long curTime) > {code} > -------------------------------------------------------------- > One more thing that I believe needs to change in DRF mode is : during a p= reemption round,if preempting a few containers results in satisfying needs = of a resource type, then we should exit that preemption round, since the co= ntainers that we just preempted should bring the dominant resource usage to= min/fair share. -- This message was sent by Atlassian JIRA (v6.3.4#6332)