Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D6FD4187AA for ; Mon, 13 Jul 2015 06:17:05 +0000 (UTC) Received: (qmail 79040 invoked by uid 500); 13 Jul 2015 06:17:05 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 78992 invoked by uid 500); 13 Jul 2015 06:17:05 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 78980 invoked by uid 99); 13 Jul 2015 06:17:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Jul 2015 06:17:05 +0000 Date: Mon, 13 Jul 2015 06:17:05 +0000 (UTC) From: "Akira AJISAKA (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-3381) A typographical error in "InvalidStateTransitonException" MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-3381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14624255#comment-14624255 ] Akira AJISAKA commented on YARN-3381: ------------------------------------- Thank you for updating the patch. I have 2 comments. {code} +/** + * Hook for InvalidTransition States. + * + */ {code} 1. There are no state for {{InvalidTransition}} and this class is not a hook but a exception. I'm thinking it's better to write as follows: {code} /** The exception that happens when you call invalid state transition. */ {code} 2. When you deprecate a class, you need to write a javadoc to specify the new class as follows: {code} /** @deprecated Use {@link InvalidStateTransitionException} instead. */ {code} > A typographical error in "InvalidStateTransitonException" > --------------------------------------------------------- > > Key: YARN-3381 > URL: https://issues.apache.org/jira/browse/YARN-3381 > Project: Hadoop YARN > Issue Type: Improvement > Components: api > Affects Versions: 2.6.0 > Reporter: Xiaoshuang LU > Assignee: Brahma Reddy Battula > Labels: BB2015-05-TBR > Attachments: YARN-3381-002.patch, YARN-3381-003.patch, YARN-3381-004-branch-2.patch, YARN-3381-004.patch, YARN-3381-005.patch, YARN-3381-006.patch, YARN-3381-007.patch, YARN-3381-008.patch, YARN-3381-010.patch, YARN-3381.patch > > > Appears that "InvalidStateTransitonException" should be "InvalidStateTransitionException". Transition was misspelled. -- This message was sent by Atlassian JIRA (v6.3.4#6332)