hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3963) AddNodeLabel on duplicate label addition shows success
Date Mon, 27 Jul 2015 21:10:05 GMT

    [ https://issues.apache.org/jira/browse/YARN-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14643400#comment-14643400
] 

Hadoop QA commented on YARN-3963:
---------------------------------

\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  17m 32s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags.
|
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to include 1 new
or modified test files. |
| {color:green}+1{color} | javac |   8m  3s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 56s | There were no new javadoc warning messages.
|
| {color:green}+1{color} | release audit |   0m 24s | The applied patch does not increase
the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   0m 56s | There were no new checkstyle issues. |
| {color:green}+1{color} | whitespace |   0m  1s | The patch has no lines that end in whitespace.
|
| {color:green}+1{color} | install |   1m 21s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with eclipse:eclipse.
|
| {color:green}+1{color} | findbugs |   1m 36s | The patch does not introduce any new Findbugs
(version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests |   1m 55s | Tests passed in hadoop-yarn-common. |
| | |  42m 20s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12747408/0004-YARN-3963.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / f36835f |
| hadoop-yarn-common test log | https://builds.apache.org/job/PreCommit-YARN-Build/8681/artifact/patchprocess/testrun_hadoop-yarn-common.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/8681/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/8681/console |


This message was automatically generated.

> AddNodeLabel on duplicate label addition shows success 
> -------------------------------------------------------
>
>                 Key: YARN-3963
>                 URL: https://issues.apache.org/jira/browse/YARN-3963
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>            Priority: Minor
>         Attachments: 0001-YARN-3963.patch, 0002-YARN-3963.patch, 0003-YARN-3963.patch,
0004-YARN-3963.patch
>
>
> Currently as per the code in {{CommonNodeLabelManager#addToClusterNodeLabels}} when we
add same nodelabel again event will not be fired so no updation is done. 
>  
> {noformat}
> ./yarn rmadmin –addToClusterNodeLabels x
> ./yarn rmadmin –addToClusterNodeLabels “x(exclusive=true)”
> ./yarn rmadmin –addToClusterNodeLabels “x(exclusive=false)”
>  {noformat}
> All these commands will give success when applied again through CLI 
>  
> {code}
> 2015-07-22 21:16:57,779 INFO org.apache.hadoop.yarn.nodelabels.CommonNodeLabelsManager:
Add labels: [<z:exclusivity=true>]
> 2015-07-22 21:16:57,779 INFO org.apache.hadoop.yarn.server.resourcemanager.RMAuditLogger:
USER=dsperf   IP=10.19.92.117 OPERATION=addToClusterNodeLabels        TARGET=AdminService
    RESULT=SUCCESS
> 2015-07-22 21:17:06,431 INFO org.apache.hadoop.yarn.nodelabels.CommonNodeLabelsManager:
Add labels: [<z:exclusivity=false>]
> 2015-07-22 21:17:06,431 INFO org.apache.hadoop.yarn.server.resourcemanager.RMAuditLogger:
USER=dsperf   IP=<IP> OPERATION=addToClusterNodeLabels        TARGET=AdminService  
  RESULT=SUCCESS
>  {code}
> Also since exclusive=true to false is not supported success is misleading



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message