hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3963) AddNodeLabel on duplicate label addition shows success
Date Mon, 27 Jul 2015 17:57:05 GMT

    [ https://issues.apache.org/jira/browse/YARN-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14643116#comment-14643116
] 

Wangda Tan commented on YARN-3963:
----------------------------------

I think we shouldn't throw exception in this case. It's better to print some WARN message
at client side when trying to add existed labels, but currently YARN lack of channel to put
diagnostic information. I would prefer to print WARN message at service side, and keeps the
behavior unchanged.

Thoughts? [~sunilg], [~bibinchundatt].

> AddNodeLabel on duplicate label addition shows success 
> -------------------------------------------------------
>
>                 Key: YARN-3963
>                 URL: https://issues.apache.org/jira/browse/YARN-3963
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>            Priority: Minor
>         Attachments: 0001-YARN-3963.patch, 0002-YARN-3963.patch
>
>
> Currently as per the code in {{CommonNodeLabelManager#addToClusterNodeLabels}} when we
add same nodelabel again event will not be fired so no updation is done. 
>  
> {noformat}
> ./yarn rmadmin –addToClusterNodeLabels x
> ./yarn rmadmin –addToClusterNodeLabels “x(exclusive=true)”
> ./yarn rmadmin –addToClusterNodeLabels “x(exclusive=false)”
>  {noformat}
> All these commands will give success when applied again through CLI 
>  
> {code}
> 2015-07-22 21:16:57,779 INFO org.apache.hadoop.yarn.nodelabels.CommonNodeLabelsManager:
Add labels: [<z:exclusivity=true>]
> 2015-07-22 21:16:57,779 INFO org.apache.hadoop.yarn.server.resourcemanager.RMAuditLogger:
USER=dsperf   IP=10.19.92.117 OPERATION=addToClusterNodeLabels        TARGET=AdminService
    RESULT=SUCCESS
> 2015-07-22 21:17:06,431 INFO org.apache.hadoop.yarn.nodelabels.CommonNodeLabelsManager:
Add labels: [<z:exclusivity=false>]
> 2015-07-22 21:17:06,431 INFO org.apache.hadoop.yarn.server.resourcemanager.RMAuditLogger:
USER=dsperf   IP=<IP> OPERATION=addToClusterNodeLabels        TARGET=AdminService  
  RESULT=SUCCESS
>  {code}
> Also since exclusive=true to false is not supported success is misleading



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message