hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Douglas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3877) YarnClientImpl.submitApplication swallows exceptions
Date Tue, 14 Jul 2015 20:54:05 GMT

    [ https://issues.apache.org/jira/browse/YARN-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627026#comment-14627026
] 

Chris Douglas commented on YARN-3877:
-------------------------------------

* Not sure I understand this change:
{noformat}
+    conf.setLong(YarnConfiguration.
+        YARN_CLIENT_APPLICATION_CLIENT_PROTOCOL_POLL_TIMEOUT_MS, 2000);
{noformat}
It seems like it would introduce timing bugs rather than prevent them. The {{\@Test}} timeout
should prevent the test from hanging; if the poll timeout fires before the interrupt is triggered,
then the unit test will fail. Does config enforce a property that would be unverified without
it?
* If necessary, then it should probably also be relative to {{pollIntervalMs}}
* This should probably be a separate test, instead of a subsection of {{testSubmitApplication}}

> YarnClientImpl.submitApplication swallows exceptions
> ----------------------------------------------------
>
>                 Key: YARN-3877
>                 URL: https://issues.apache.org/jira/browse/YARN-3877
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 2.7.2
>            Reporter: Steve Loughran
>            Assignee: Varun Saxena
>            Priority: Minor
>         Attachments: YARN-3877.01.patch
>
>
> When {{YarnClientImpl.submitApplication}} spins waiting for the application to be accepted,
any interruption during its Sleep() calls are logged and swallowed.
> this makes it hard to interrupt the thread during shutdown. Really it should throw some
form of exception and let the caller deal with it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message