hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3867) ContainerImpl changes to support container resizing
Date Thu, 23 Jul 2015 23:47:05 GMT

    [ https://issues.apache.org/jira/browse/YARN-3867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14639682#comment-14639682
] 

Jian He commented on YARN-3867:
-------------------------------

thanks [~mding], some comments on the patch:
- CHANGE_CONTAINER_RESOURCE/ChangeContainerResourceTransition: how about sending the changeEvent
directly into ContainerMonitorImpl from ContainerManagerImpl? this saves one hop of event
and transition through the ContainerImpl
- ChangeMonitoringContainerResourceEvent: how about just passing in the Resource object and
move the vmem/pmem re-size specific logic into containerMonitorImpl ?
- we may use volatile keyword for this.resource ?
{code}
this.readLock.lock();
try {
  return Resource.newInstance(this.resource.getMemory(),

     this.resource.getVirtualCores());
} finally {
  this.readLock.unlock();
}
{code}

> ContainerImpl changes to support container resizing
> ---------------------------------------------------
>
>                 Key: YARN-3867
>                 URL: https://issues.apache.org/jira/browse/YARN-3867
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>            Reporter: MENG DING
>            Assignee: MENG DING
>         Attachments: YARN-3867-YARN-1197.3.patch, YARN-3867.1.patch, YARN-3867.2.patch
>
>
> 1) ContainerImpl logic changes in NM to handle events related to container resizing
> 2) Relevant test cases



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message