hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing
Date Wed, 08 Jul 2015 23:37:05 GMT

    [ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619590#comment-14619590
] 

Jian He commented on YARN-3866:
-------------------------------

[~mding], thanks for the work ! some comments on the patch:

- Mark all getters/setters unstable for now.
- DecreasedContainer.java/IncreasedContainer.java - how about reusing the Container.java object?
- increaseRequests/decreaseRequests - We may just pass one list of changeResourceRequests
instead of differentiating whether it’s increase or decrease ? as the underlying implementations
are the same. IMO, this also saves application writers from differentiating them programmatically.

{code}
List<ContainerResourceChangeRequest> increaseRequests,

List<ContainerResourceChangeRequest> decreaseRequests) 
{code}


> AM-RM protocol changes to support container resizing
> ----------------------------------------------------
>
>                 Key: YARN-3866
>                 URL: https://issues.apache.org/jira/browse/YARN-3866
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api
>            Reporter: MENG DING
>            Assignee: MENG DING
>         Attachments: YARN-3866.1.patch, YARN-3866.2.patch
>
>
> YARN-1447 and YARN-1448 are outdated. 
> This ticket deals with AM-RM Protocol changes to support container resize according to
the latest design in YARN-1197.
> 1) Add increase/decrease requests in AllocateRequest
> 2) Get approved increase/decrease requests from RM in AllocateResponse
> 3) Add relevant test cases



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message