hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arun Suresh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3535) ResourceRequest should be restored back to scheduler when RMContainer is killed at ALLOCATED
Date Wed, 15 Jul 2015 01:07:05 GMT

    [ https://issues.apache.org/jira/browse/YARN-3535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627370#comment-14627370

Arun Suresh commented on YARN-3535:

Apologies for the late suggestion.

[~djp], Correct me if I am wrong here.. I was just looking at YARN-2561. It looks like the
basic point of it was to ensure that on a reconnecting node, running containers were properly
killed. This is achieved by the node removed and node added event. This happens in the {{if
(noRunningApps) ..}} clause of the YARN-2561 patch.

But I also see that a later patch has also handled the issue by introducing the following
code inside the {{else ..}} clause of the above mentioned if.

        for (ApplicationId appId : reconnectEvent.getRunningApplications()) {
          handleRunningAppOnNode(rmNode, rmNode.context, appId, rmNode.nodeId);

This correctly kills only the running contains and does not do anything to the allocated containers
(which I guess should be the case).

Given the above, do we still need whatever is contained in the if clause ? wouldn't removing
the if clause just solve this ?

Thoughts ?

>  ResourceRequest should be restored back to scheduler when RMContainer is killed at ALLOCATED
> ---------------------------------------------------------------------------------------------
>                 Key: YARN-3535
>                 URL: https://issues.apache.org/jira/browse/YARN-3535
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Peng Zhang
>            Assignee: Peng Zhang
>            Priority: Critical
>         Attachments: 0003-YARN-3535.patch, YARN-3535-001.patch, YARN-3535-002.patch,
syslog.tgz, yarn-app.log
> During rolling update of NM, AM start of container on NM failed. 
> And then job hang there.
> Attach AM logs.

This message was sent by Atlassian JIRA

View raw message