hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sangjin Lee (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3051) [Storage abstraction] Create backing storage read interface for ATS readers
Date Mon, 06 Jul 2015 17:35:05 GMT

    [ https://issues.apache.org/jira/browse/YARN-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615354#comment-14615354
] 

Sangjin Lee commented on YARN-3051:
-----------------------------------

Thanks [~varun_saxena] for providing a quick update! My latest comments are mostly on FileSystemTimelineReaderImpl.java.

- l.151-152: [~zjshen] previously pointed this out but I don't see this changed in the latest
patch. Do info values have to be converted into strings to be compared for equality? Is it
because you worry about the info value types not implementing equals()? Can we not assume
that it is expected for the info value types to provide sensible equals() implementations?
- l.192: How do you deal with a situation where "," is used in the tokens themselves? Note
that flow names may contain commas (there is no reason they cannot). The separators should
be escaped on the way in and unescaped on the way out. And it'd be good to have some unit
tests for this case.
- l.220: matchMetricFilters() is static while matchEventFilters() is not. Could you make it
consistent across all private helper methods?
- l.249: nit: it can be a simple return statement instead of the if clause.


> [Storage abstraction] Create backing storage read interface for ATS readers
> ---------------------------------------------------------------------------
>
>                 Key: YARN-3051
>                 URL: https://issues.apache.org/jira/browse/YARN-3051
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Sangjin Lee
>            Assignee: Varun Saxena
>         Attachments: YARN-3051-YARN-2928.003.patch, YARN-3051-YARN-2928.03.patch, YARN-3051-YARN-2928.04.patch,
YARN-3051-YARN-2928.05.patch, YARN-3051-YARN-2928.06.patch, YARN-3051-YARN-2928.07.patch,
YARN-3051.Reader_API.patch, YARN-3051.Reader_API_1.patch, YARN-3051.Reader_API_2.patch, YARN-3051.Reader_API_3.patch,
YARN-3051.Reader_API_4.patch, YARN-3051.wip.02.YARN-2928.patch, YARN-3051.wip.patch, YARN-3051_temp.patch
>
>
> Per design in YARN-2928, create backing storage read interface that can be implemented
by multiple backing storage implementations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message