hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sangjin Lee (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3047) [Data Serving] Set up ATS reader with basic request serving structure and lifecycle
Date Mon, 06 Jul 2015 21:50:05 GMT

    [ https://issues.apache.org/jira/browse/YARN-3047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615729#comment-14615729
] 

Sangjin Lee commented on YARN-3047:
-----------------------------------

Thanks [~varun_saxena] for the latest patch.

(TestTimelineReaderWebServices.java)
- l.54-71: I think there is a simpler solution to this than implementing the method for getting
the next available port and exposing internals of TimelineReaderWebServices to do it. Why
not set TIMELINE_READER_WEBAPP_ADDRESS to something like "http://localhost:0"? HttpServer2
itself is able to do all this if it is passed port 0.

(TimelineReaderServer.java)
- l.52-57: nit: grouping of variables; I believe the convention is to group all the static
variables in one and all the instance variables in another



> [Data Serving] Set up ATS reader with basic request serving structure and lifecycle
> -----------------------------------------------------------------------------------
>
>                 Key: YARN-3047
>                 URL: https://issues.apache.org/jira/browse/YARN-3047
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Sangjin Lee
>            Assignee: Varun Saxena
>              Labels: BB2015-05-TBR
>         Attachments: Timeline_Reader(draft).pdf, YARN-3047-YARN-2928.08.patch, YARN-3047-YARN-2928.09.patch,
YARN-3047-YARN-2928.10.patch, YARN-3047.001.patch, YARN-3047.003.patch, YARN-3047.005.patch,
YARN-3047.006.patch, YARN-3047.007.patch, YARN-3047.02.patch, YARN-3047.04.patch
>
>
> Per design in YARN-2938, set up the ATS reader as a service and implement the basic structure
as a service. It includes lifecycle management, request serving, and so on.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message