Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 32D2218B3A for ; Mon, 22 Jun 2015 23:34:01 +0000 (UTC) Received: (qmail 46743 invoked by uid 500); 22 Jun 2015 23:34:01 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 46699 invoked by uid 500); 22 Jun 2015 23:34:01 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 46687 invoked by uid 99); 22 Jun 2015 23:34:01 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Jun 2015 23:34:01 +0000 Date: Mon, 22 Jun 2015 23:34:00 +0000 (UTC) From: "zhihai xu (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-3843) Fair Scheduler should not accept apps with space keys as queue name MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-3843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14596848#comment-14596848 ] zhihai xu commented on YARN-3843: --------------------------------- Hi [~dongwook], thanks for reporting this issue. I think this issue was fixed at YARN-3241. > Fair Scheduler should not accept apps with space keys as queue name > ------------------------------------------------------------------- > > Key: YARN-3843 > URL: https://issues.apache.org/jira/browse/YARN-3843 > Project: Hadoop YARN > Issue Type: Bug > Components: fairscheduler > Affects Versions: 2.4.0, 2.5.0 > Reporter: Dongwook Kwon > Priority: Minor > > As YARN-461, since empty string queue name is not valid, queue name with space keys such as " " ," " should not be accepted either, also not as prefix nor postfix. > e.g) "root.test.queuename ", or "root.test. queuename" > I have 2 specific cases kill RM with these space keys as part of queue name. > 1) Without placement policy (hadoop 2.4.0 and above), > When a job is submitted with " "(space key) as queue name > e.g) mapreduce.job.queuename=" " > 2) With placement policy (hadoop 2.5.0 and above) > Once a job is submitted without space key as queue name, and submit another job with space key. > e.g) 1st time: mapreduce.job.queuename="root.test.user1" > 2nd time: mapreduce.job.queuename="root.test.user1 " > {code} > Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.974 sec <<< FAILURE! - in org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairScheduler > testQueueNameWithSpace(org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairScheduler) Time elapsed: 0.724 sec <<< ERROR! > org.apache.hadoop.metrics2.MetricsException: Metrics source QueueMetrics,q0=root,q1=adhoc,q2=birvine already exists! > at org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.newSourceName(DefaultMetricsSystem.java:135) > at org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.sourceName(DefaultMetricsSystem.java:112) > at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.register(MetricsSystemImpl.java:218) > at org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSQueueMetrics.forQueue(FSQueueMetrics.java:96) > at org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSQueue.(FSQueue.java:56) > at org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSLeafQueue.(FSLeafQueue.java:66) > at org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.QueueManager.createQueue(QueueManager.java:169) > at org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.QueueManager.getQueue(QueueManager.java:120) > at org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.QueueManager.getLeafQueue(QueueManager.java:88) > at org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler.assignToQueue(FairScheduler.java:660) > at org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler.addApplication(FairScheduler.java:569) > at org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler.handle(FairScheduler.java:1127) > at org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairScheduler.testQueueNameWithSpace(TestFairScheduler.java:627) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)