Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 540A0183AC for ; Mon, 8 Jun 2015 18:39:07 +0000 (UTC) Received: (qmail 90758 invoked by uid 500); 8 Jun 2015 18:39:01 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 90716 invoked by uid 500); 8 Jun 2015 18:39:01 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 90700 invoked by uid 99); 8 Jun 2015 18:39:00 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Jun 2015 18:39:00 +0000 Date: Mon, 8 Jun 2015 18:39:00 +0000 (UTC) From: "Zhijie Shen (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-3787) loading applications by filtering appstartedTime period for ATS Web UI MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-3787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577624#comment-14577624 ] Zhijie Shen commented on YARN-3787: ----------------------------------- The patch looks good to me overall. Some comments: 1. "startedTimeBegin" -> "app.started-time.begin" and "startedTimeEnd" -> "app.started-time.end"? {code} 36 String APP_START_TIME_BEGIN = "startedTimeBegin"; 37 String APP_START_TIME_END = "startedTimeEnd"; {code} 2. This semantics enforced for appblocks is conflicting with webservices. {code} 103 if (appStartedTimeBegain > appStartedTimeEnd) { 104 throw new BadRequestException( 105 "startedTimeEnd must be greater than startTimeBegin"); 106 } {code} > loading applications by filtering appstartedTime period for ATS Web UI > ---------------------------------------------------------------------- > > Key: YARN-3787 > URL: https://issues.apache.org/jira/browse/YARN-3787 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager, webapp, yarn > Reporter: Xuan Gong > Assignee: Xuan Gong > Attachments: YARN-3787.1.patch > > > After YARN-3700, we have defined a parameter called apps.num for loading a given number of applications in ats web page. > We could also define several additional parameters for the similar purpose. -- This message was sent by Atlassian JIRA (v6.3.4#6332)