Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Wed, 3 Jun 2015 18:49:38 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12818693.1428352984000.3106.1433357378743@Atlassian.JIRA>
In-Reply-To: <JIRA.12818693.1428352984000@Atlassian.JIRA>
References: <JIRA.12818693.1428352984000@Atlassian.JIRA>
 <JIRA.12818693.1428352984302@arcas>
Subject: [jira] [Commented] (YARN-3453) Fair Scheduler : Parts of preemption
 logic uses DefaultResourceCalculator even in DRF mode causing thrashing
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/YARN-3453?page=3Dcom.atlassian.=
jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D14571=
480#comment-14571480 ]=20

Hadoop QA commented on YARN-3453:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  15m 55s | Pre-patch trunk compilation=
 is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain =
any @author tags. |
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appe=
ar to include any new or modified tests.  Please justify why no new tests a=
re needed for this patch. Also please list what manual steps were performed=
 to verify this patch. |
| {color:green}+1{color} | javac |   7m 37s | There were no new javac warni=
ng messages. |
| {color:green}+1{color} | javadoc |   9m 35s | There were no new javadoc w=
arning messages. |
| {color:green}+1{color} | release audit |   0m 23s | The applied patch doe=
s not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   0m 46s | There were no new checks=
tyle issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines t=
hat end in whitespace. |
| {color:green}+1{color} | install |   1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built wit=
h eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   1m 25s | The patch does not introdu=
ce any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests |  50m 14s | Tests passed in hadoop-y=
arn-server-resourcemanager. |
| | |  88m 10s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12737319/YARN=
-3453.1.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / c59e745 |
| hadoop-yarn-server-resourcemanager test log | https://builds.apache.org/j=
ob/PreCommit-YARN-Build/8179/artifact/patchprocess/testrun_hadoop-yarn-serv=
er-resourcemanager.txt |
| Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/8179/te=
stReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SM=
P PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/8179/=
console |


This message was automatically generated.

> Fair Scheduler : Parts of preemption logic uses DefaultResourceCalculator=
 even in DRF mode causing thrashing
> -------------------------------------------------------------------------=
-----------------------------------
>
>                 Key: YARN-3453
>                 URL: https://issues.apache.org/jira/browse/YARN-3453
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler
>    Affects Versions: 2.6.0
>            Reporter: Ashwin Shankar
>            Assignee: Arun Suresh
>         Attachments: YARN-3453.1.patch
>
>
> There are two places in preemption code flow where DefaultResourceCalcula=
tor is used, even in DRF mode.
> Which basically results in more resources getting preempted than needed, =
and those extra preempted containers aren=E2=80=99t even getting to the =E2=
=80=9Cstarved=E2=80=9D queue since scheduling logic is based on DRF's Calcu=
lator.
> Following are the two places :
> 1. {code:title=3DFSLeafQueue.java|borderStyle=3Dsolid}
> private boolean isStarved(Resource share)
> {code}
> A queue shouldn=E2=80=99t be marked as =E2=80=9Cstarved=E2=80=9D if the d=
ominant resource usage
> is >=3D  fair/minshare.
> 2. {code:title=3DFairScheduler.java|borderStyle=3Dsolid}
> protected Resource resToPreempt(FSLeafQueue sched, long curTime)
> {code}
> --------------------------------------------------------------
> One more thing that I believe needs to change in DRF mode is : during a p=
reemption round,if preempting a few containers results in satisfying needs =
of a resource type, then we should exit that preemption round, since the co=
ntainers that we just preempted should bring the dominant resource usage to=
 min/fair share.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)