Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Thu, 4 Jun 2015 11:41:38 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12747196.1412912278000.10217.1433418098868@Atlassian.JIRA>
In-Reply-To: <JIRA.12747196.1412912278000@Atlassian.JIRA>
References: <JIRA.12747196.1412912278000@Atlassian.JIRA>
 <JIRA.12747196.1412912278285@arcas>
Subject: [jira] [Commented] (YARN-2674) Distributed shell AM may re-launch
 containers if RM work preserving restart happens
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572604#comment-14572604 ] 

Hadoop QA commented on YARN-2674:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  15m 42s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to include 4 new or modified test files. |
| {color:red}-1{color} | javac |   7m 32s | The applied patch generated  1  additional warning messages. |
| {color:green}+1{color} | javadoc |   9m 36s | There were no new javadoc warning messages. |
| {color:green}+1{color} | release audit |   0m 22s | The applied patch does not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   0m 39s | There were no new checkstyle issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace. |
| {color:green}+1{color} | install |   1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with eclipse:eclipse. |
| {color:red}-1{color} | findbugs |   1m 30s | The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings. |
| {color:red}-1{color} | yarn tests |   1m  3s | Tests failed in hadoop-yarn-applications-distributedshell. |
| {color:green}+1{color} | yarn tests |   1m 52s | Tests passed in hadoop-yarn-server-tests. |
| | |  40m 27s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-yarn-applications-distributedshell |
| Failed unit tests | hadoop.yarn.applications.distributedshell.TestDistributedShellWithNodeLabels |
|   | hadoop.yarn.applications.distributedshell.TestDSAppMaster |
|   | hadoop.yarn.applications.distributedshell.TestDistributedShell |
|   | hadoop.yarn.applications.distributedshell.TestDistributedShellWithRMHA |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12737533/YARN-2674.3.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / e830207 |
| javac | https://builds.apache.org/job/PreCommit-YARN-Build/8193/artifact/patchprocess/diffJavacWarnings.txt |
| Findbugs warnings | https://builds.apache.org/job/PreCommit-YARN-Build/8193/artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-applications-distributedshell.html |
| hadoop-yarn-applications-distributedshell test log | https://builds.apache.org/job/PreCommit-YARN-Build/8193/artifact/patchprocess/testrun_hadoop-yarn-applications-distributedshell.txt |
| hadoop-yarn-server-tests test log | https://builds.apache.org/job/PreCommit-YARN-Build/8193/artifact/patchprocess/testrun_hadoop-yarn-server-tests.txt |
| Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/8193/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/8193/console |


This message was automatically generated.

> Distributed shell AM may re-launch containers if RM work preserving restart happens
> -----------------------------------------------------------------------------------
>
>                 Key: YARN-2674
>                 URL: https://issues.apache.org/jira/browse/YARN-2674
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Chun Chen
>            Assignee: Chun Chen
>         Attachments: YARN-2674.1.patch, YARN-2674.2.patch, YARN-2674.3.patch
>
>
> Currently, if RM work preserving restart happens while distributed shell is running, distribute shell AM may re-launch all the containers, including new/running/complete. We must make sure it won't re-launch the running/complete containers.
> We need to remove allocated containers from AMRMClientImpl#remoteRequestsTable once AM receive them from RM. 


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)