hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Subru Krishnan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3800) Simplify inmemory state for ReservationAllocation
Date Mon, 22 Jun 2015 21:26:02 GMT

    [ https://issues.apache.org/jira/browse/YARN-3800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14596663#comment-14596663

Subru Krishnan commented on YARN-3800:

Thanks [~adhoot] for the patch. I looked at it & just had a couple of comments:
   1. Can we have _toResource(ReservationRequest request)_ in a Reservation utility class
rather than in _InMemoryReservationAllocation_
   2. I feel we can update the constructor of _InMemoryReservationAllocation_ to take in _Map<ReservationInterval,
Resource>_ instead of _Map<ReservationInterval, ReservationRequest>_ so that we do
the translation only once. This should simplify the state in GreedyReservationAgent also.

> Simplify inmemory state for ReservationAllocation
> -------------------------------------------------
>                 Key: YARN-3800
>                 URL: https://issues.apache.org/jira/browse/YARN-3800
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler, fairscheduler, resourcemanager
>            Reporter: Anubhav Dhoot
>            Assignee: Anubhav Dhoot
>         Attachments: YARN-3800.001.patch, YARN-3800.002.patch
> Instead of storing the ReservationRequest we store the Resource for allocations, as thats
the only thing we need. Ultimately we convert everything to resources anyway

This message was sent by Atlassian JIRA

View raw message