hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3794) TestRMEmbeddedElector fails because of ambiguous LOG reference
Date Fri, 12 Jun 2015 14:44:01 GMT

    [ https://issues.apache.org/jira/browse/YARN-3794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14583509#comment-14583509
] 

Hudson commented on YARN-3794:
------------------------------

SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #215 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/215/])
YARN-3794. TestRMEmbeddedElector fails because of ambiguous LOG reference. (devaraj: rev d8dcfa98e3ca6a6fea414fd503589bb83b7a9c51)
* hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMEmbeddedElector.java
* hadoop-yarn-project/CHANGES.txt


> TestRMEmbeddedElector fails because of ambiguous LOG reference
> --------------------------------------------------------------
>
>                 Key: YARN-3794
>                 URL: https://issues.apache.org/jira/browse/YARN-3794
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.7.0
>            Reporter: Chengbing Liu
>            Assignee: Chengbing Liu
>             Fix For: 2.8.0
>
>         Attachments: YARN-3794.01.patch
>
>
> After YARN-2921, {{MockRM}} has also a {{LOG}} field. Therefore {{LOG}} in the following
code snippet is ambiguous.
> {code}
>     protected AdminService createAdminService() {
>       return new AdminService(MockRMWithElector.this, getRMContext()) {
>         @Override
>         protected EmbeddedElectorService createEmbeddedElectorService() {
>           return new EmbeddedElectorService(getRMContext()) {
>             @Override
>             public void becomeActive() throws
>                 ServiceFailedException {
>               try {
>                 callbackCalled.set(true);
>                 LOG.info("Callback called. Sleeping now");
>                 Thread.sleep(delayMs);
>                 LOG.info("Sleep done");
>               } catch (InterruptedException e) {
>                 e.printStackTrace();
>               }
>               super.becomeActive();
>             }
>           };
>         }
>       };
>     }
> {code}
> Eclipse gives the following error:
> {quote}
> The field LOG is defined in an inherited type and an enclosing scope
> {quote}
> IMO, we should fix this as {{TestRMEmbeddedElector.LOG}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message