hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Naganarasimha G R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3792) Test case failures in TestDistributedShell and some issue fixes related to ATSV2
Date Sun, 14 Jun 2015 20:45:01 GMT

    [ https://issues.apache.org/jira/browse/YARN-3792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14585263#comment-14585263

Naganarasimha G R commented on YARN-3792:

Uploading the patch with the fixes for the mentioned issues.
Analysis for few issues which might require review/discussion :
* Issue1 : {{TestDistributedShell.testDSShellWithoutDomainV2CustomizedFlow}} was failing when
all the test cases was run because of the ExecutorService was statically initialized and was
shutdown on the service stop in the initial run
{{TestDistributedShell.testDSShellWithoutDomainV2DefaultFlow}} was failing because of NodeTimelineCollectorManager
was singleton service used in PerNodeTimelineCollectorsAuxService, i feel singleton reference
was not required as it was used only by the NodeTimelineCollectorManager. /cc [~djp], please
review the modifications are fine for this check in specific.
{{TestDistributedShellWithNodeLabels.testDSShellWithNodeLabelExpression}} was failing because
method name rule will not set be set in TestDistributedShell.setupInternal.
* Issue 4: Hope the fix given in {{TimelineClientImpl.putObjects}} is sufficient for this.
* Issue 6: Not sure why tags are converted to lower case in {{ApplicationSubmissionContextPBImpl.setApplicationTags}}.
Currently have done the modifications at our end {{RMTimelineCollectorManager.postPut}}. But
seems this needs to be corrected in ApplicationSubmissionContextPBImpl, based on suggestions
can rework on this. Also tried to check the history/log was not able to find the source of
this change.

Other trivial issues has been handled.
[~zjshen], [~djp] & [~sjlee0],  please review...

> Test case failures in TestDistributedShell and some issue fixes related to ATSV2
> --------------------------------------------------------------------------------
>                 Key: YARN-3792
>                 URL: https://issues.apache.org/jira/browse/YARN-3792
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>         Attachments: YARN-3792-YARN-2928.001.patch
> # encountered [testcase failures|https://builds.apache.org/job/PreCommit-YARN-Build/8233/testReport/]
which was happening even without the patch modifications in YARN-3044
> TestDistributedShell.testDSShellWithoutDomainV2CustomizedFlow
> TestDistributedShell.testDSShellWithoutDomainV2DefaultFlow
> TestDistributedShellWithNodeLabels.testDSShellWithNodeLabelExpression
> # Remove unused {{enableATSV1}} in testDisstributedShell
> # container metrics needs to be published only for v2 test cases of testDisstributedShell
> # Nullpointer was thrown in TimelineClientImpl.constructResURI when Aux service was not
configured and {{TimelineClient.putObjects}} was getting invoked.
> # Race condition for the Application events to published and test case verification for
RM's ApplicationFinished Timeline Events
> # Application Tags for converted to lowercase in ApplicationSubmissionContextPBimpl,
hence RMTimelinecollector was not able to detect to custom flow details of the app

This message was sent by Atlassian JIRA

View raw message