hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3770) SerializedException should also handle java.lang.Error
Date Fri, 05 Jun 2015 12:51:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-3770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574439#comment-14574439
] 

Hadoop QA commented on YARN-3770:
---------------------------------

\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  16m  1s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags.
|
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to include 1 new
or modified test files. |
| {color:green}+1{color} | javac |   7m 22s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 45s | There were no new javadoc warning messages.
|
| {color:green}+1{color} | release audit |   0m 23s | The applied patch does not increase
the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   0m 52s | There were no new checkstyle issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace.
|
| {color:green}+1{color} | install |   1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 31s | The patch built with eclipse:eclipse.
|
| {color:green}+1{color} | findbugs |   1m 31s | The patch does not introduce any new Findbugs
(version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests |   1m 55s | Tests passed in hadoop-yarn-common. |
| | |  39m 58s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12737919/YARN-3770.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 790a861 |
| hadoop-yarn-common test log | https://builds.apache.org/job/PreCommit-YARN-Build/8197/artifact/patchprocess/testrun_hadoop-yarn-common.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/8197/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/8197/console |


This message was automatically generated.

> SerializedException should also handle java.lang.Error 
> -------------------------------------------------------
>
>                 Key: YARN-3770
>                 URL: https://issues.apache.org/jira/browse/YARN-3770
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Lavkesh Lahngir
>            Assignee: Lavkesh Lahngir
>         Attachments: YARN-3770.patch
>
>
> IN SerializedExceptionPBImpl deserialize() method
> {code}
>     Class classType = null;
>     if (YarnException.class.isAssignableFrom(realClass)) {
>       classType = YarnException.class;
>     } else if (IOException.class.isAssignableFrom(realClass)) {
>       classType = IOException.class;
>     } else if (RuntimeException.class.isAssignableFrom(realClass)) {
>       classType = RuntimeException.class;
>     } else {
>       classType = Exception.class;
>     }
>     return instantiateException(realClass.asSubclass(classType), getMessage(),
>       cause == null ? null : cause.deSerialize());
>   }
> {code}
> if realClass is a subclass of java.lang.Error deSerialize() throws ClassCastException.
> in the last else statement classType should be equal to Trowable.class instead of Exception.class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message