hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gera Shegalov (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (YARN-3768) Index out of range exception with environment variables without values
Date Tue, 30 Jun 2015 00:18:05 GMT

     [ https://issues.apache.org/jira/browse/YARN-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Gera Shegalov updated YARN-3768:
    Attachment: YARN-3768.003.patch

Thanks for reviewing the patch, [~zxu]! 

bq. If the input is "a=b=c", it saves Env variable "a" with value "b". Is it correct? 
Correct, and I agree it does not look the behavior we want. I think the right behavior is
to accept any value between the first {{=}} and the next {{,}}. The value should be {{b=c}}
in your example.

bq. I also noticed the patch will discard Env Variable with empty string value. I am ok with
I think it might be desirable sometimes to clear a variable that is is set globally.  Let
us allow it.

003 patch attached!

> Index out of range exception with environment variables without values
> ----------------------------------------------------------------------
>                 Key: YARN-3768
>                 URL: https://issues.apache.org/jira/browse/YARN-3768
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: yarn
>    Affects Versions: 2.5.0
>            Reporter: Joe Ferner
>            Assignee: zhihai xu
>         Attachments: YARN-3768.000.patch, YARN-3768.001.patch, YARN-3768.002.patch, YARN-3768.003.patch
> Looking at line 80 of org.apache.hadoop.yarn.util.Apps an index out of range exception
occurs if an environment variable is encountered without a value.
> I believe this occurs because java will not return empty strings from the split method.
Similar to this http://stackoverflow.com/questions/14602062/java-string-split-removed-empty-values

This message was sent by Atlassian JIRA

View raw message