hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Li Lu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (YARN-3765) Fix findbugs the warning in YARN-2928 branch, TimelineMetric
Date Wed, 03 Jun 2015 21:03:38 GMT

     [ https://issues.apache.org/jira/browse/YARN-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Li Lu updated YARN-3765:
------------------------
    Attachment: YARN-3765-YARN-2928.001.patch

I looked into the warning message, and now I believe it's not a false alarm. Previously we're
directly negating the comparison, but this may potentially hit integer overflow. A simple
fix is to reverse the direction of the comparison. 

> Fix findbugs the warning in YARN-2928 branch, TimelineMetric
> ------------------------------------------------------------
>
>                 Key: YARN-3765
>                 URL: https://issues.apache.org/jira/browse/YARN-3765
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Li Lu
>            Assignee: Li Lu
>         Attachments: YARN-3765-YARN-2928.001.patch
>
>
> There is one warning about reversing the return value of comparisons in YARN-2928 branch.
I believe this is a false alarm since we intentionally said the comparator is a "reversed"
comparator. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message