hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Li Lu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3051) [Storage abstraction] Create backing storage read interface for ATS readers
Date Mon, 29 Jun 2015 21:40:07 GMT

    [ https://issues.apache.org/jira/browse/YARN-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606458#comment-14606458
] 

Li Lu commented on YARN-3051:
-----------------------------

Hi [~varun_saxena], thanks for the patch! I think this version is much closer and we're getting
a reader-storage interface soon. The general approach looks fine, but I have one concern.
I was looking at it when I found there are a lot of code related to the detailed filter design,
like some binary relational operators. I'm not sure if in this JIRA we need to fix those filter
designs, or we simply want to have some basic, name based filters, like "filtering out entities
with metric HDFS_BYTES_WRITE". For detailed filter designs, we may need to consider our storage
level implementations like our HBase implementation. After a general skim through the rest
part of the patch I think they're fine, and I'll post detailed review of the rest part of
code soon. 

> [Storage abstraction] Create backing storage read interface for ATS readers
> ---------------------------------------------------------------------------
>
>                 Key: YARN-3051
>                 URL: https://issues.apache.org/jira/browse/YARN-3051
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Sangjin Lee
>            Assignee: Varun Saxena
>         Attachments: YARN-3051-YARN-2928.003.patch, YARN-3051-YARN-2928.03.patch, YARN-3051-YARN-2928.04.patch,
YARN-3051-YARN-2928.05.patch, YARN-3051.Reader_API.patch, YARN-3051.Reader_API_1.patch, YARN-3051.Reader_API_2.patch,
YARN-3051.Reader_API_3.patch, YARN-3051.Reader_API_4.patch, YARN-3051.wip.02.YARN-2928.patch,
YARN-3051.wip.patch, YARN-3051_temp.patch
>
>
> Per design in YARN-2928, create backing storage read interface that can be implemented
by multiple backing storage implementations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message