hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sidharta Seethana (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2194) Cgroups cease to work in RHEL7
Date Fri, 12 Jun 2015 07:57:02 GMT

    [ https://issues.apache.org/jira/browse/YARN-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14583116#comment-14583116
] 

Sidharta Seethana commented on YARN-2194:
-----------------------------------------

[~ywskycn] ,  you'll need to change {{PrivilegedOperationExecutor}} as well 

{code}
      if (noneArgsOnly == false) {
        //We have already appended at least one tasks file.
        finalOpArg.append(",");
        finalOpArg.append(tasksFile);
      } else {
        finalOpArg.append(tasksFile);
        noneArgsOnly = false;
      }
{code}


The tests appear to pass in TestLinuxContainerExecutorWithMocks,
 but it not clear why. One example in {{TestLinuxContainerExecutorWithMocks}} that should
have caused a test failure : 

{code}
StringUtils.join(",", dirsHandler.getLocalDirs()),
StringUtils.join(",", dirsHandler.getLogDirs()), "cgroups=none"),
{code}

It appears to me that this construction is done in enough places that it would make sense
to create a static constant for use as a separator when constructing an argument for the container-executor
binary. A good candidate location to add such a constant would be the {{PrivilegedOperation}}
class. You could, in addition, also ‘hide’ the join functionality by adding a static function
in the {{PrivilegedOperation}} class. 



> Cgroups cease to work in RHEL7
> ------------------------------
>
>                 Key: YARN-2194
>                 URL: https://issues.apache.org/jira/browse/YARN-2194
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.7.0
>            Reporter: Wei Yan
>            Assignee: Wei Yan
>            Priority: Critical
>         Attachments: YARN-2194-1.patch, YARN-2194-2.patch, YARN-2194-3.patch, YARN-2194-4.patch
>
>
> In RHEL7, the CPU controller is named "cpu,cpuacct". The comma in the controller name
leads to container launch failure. 
> RHEL7 deprecates libcgroup and recommends the user of systemd. However, systemd has certain
shortcomings as identified in this JIRA (see comments). 
> This JIRA only fixes the failure, and doesn't try to use systemd.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message