Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5275C18FBB for ; Fri, 29 May 2015 01:11:18 +0000 (UTC) Received: (qmail 20088 invoked by uid 500); 29 May 2015 01:11:18 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 20042 invoked by uid 500); 29 May 2015 01:11:18 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 20024 invoked by uid 99); 29 May 2015 01:11:18 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 May 2015 01:11:18 +0000 Date: Fri, 29 May 2015 01:11:17 +0000 (UTC) From: "Robert Kanter (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-3713) Remove duplicate function call storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564031#comment-14564031 ] Robert Kanter commented on YARN-3713: ------------------------------------- +1 > Remove duplicate function call storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition > ------------------------------------------------------------------------------------------------ > > Key: YARN-3713 > URL: https://issues.apache.org/jira/browse/YARN-3713 > Project: Hadoop YARN > Issue Type: Improvement > Components: nodemanager > Affects Versions: 2.7.0 > Reporter: zhihai xu > Assignee: zhihai xu > Priority: Minor > Labels: cleanup > Attachments: YARN-3713.000.patch > > > remove duplicate function call {{storeContainerDiagnostics}} in ContainerDiagnosticsUpdateTransition. {{storeContainerDiagnostics}} is already called at ContainerImpl#addDiagnostics. > {code} > private void addDiagnostics(String... diags) { > for (String s : diags) { > this.diagnostics.append(s); > } > try { > stateStore.storeContainerDiagnostics(containerId, diagnostics); > } catch (IOException e) { > LOG.warn("Unable to update diagnostics in state store for " > + containerId, e); > } > } > {code} > So we don't need call {{storeContainerDiagnostics}} in ContainerDiagnosticsUpdateTransition#transition. > {code} > container.addDiagnostics(updateEvent.getDiagnosticsUpdate(), "\n"); > try { > container.stateStore.storeContainerDiagnostics(container.containerId, > container.diagnostics); > } catch (IOException e) { > LOG.warn("Unable to update state store diagnostics for " > + container.containerId, e); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)