Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Tue, 26 May 2015 08:13:17 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12832646.1432624576000.25168.1432627997779@Atlassian.JIRA>
In-Reply-To: <JIRA.12832646.1432624576000@Atlassian.JIRA>
References: <JIRA.12832646.1432624576000@Atlassian.JIRA>
 <JIRA.12832646.1432624576517@arcas>
Subject: [jira] [Commented] (YARN-3713) Remove duplicate function call
 storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14558837#comment-14558837 ] 

Hadoop QA commented on YARN-3713:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  14m 44s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags. |
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | javac |   7m 37s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 34s | There were no new javadoc warning messages. |
| {color:green}+1{color} | release audit |   0m 23s | The applied patch does not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   0m 51s | There were no new checkstyle issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace. |
| {color:green}+1{color} | install |   1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 36s | The patch built with eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   1m  3s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests |   6m 11s | Tests passed in hadoop-yarn-server-nodemanager. |
| | |  42m 36s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12735265/YARN-3713.000.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 56996a6 |
| hadoop-yarn-server-nodemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/8080/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt |
| Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/8080/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/8080/console |


This message was automatically generated.

> Remove duplicate function call storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition
> ------------------------------------------------------------------------------------------------
>
>                 Key: YARN-3713
>                 URL: https://issues.apache.org/jira/browse/YARN-3713
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: nodemanager
>    Affects Versions: 2.7.0
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>            Priority: Minor
>              Labels: cleanup
>         Attachments: YARN-3713.000.patch
>
>
> remove duplicate function call {{storeContainerDiagnostics}} in ContainerDiagnosticsUpdateTransition. {{storeContainerDiagnostics}} is already called at ContainerImpl#addDiagnostics. 
> {code}
>   private void addDiagnostics(String... diags) {
>     for (String s : diags) {
>       this.diagnostics.append(s);
>     }
>     try {
>       stateStore.storeContainerDiagnostics(containerId, diagnostics);
>     } catch (IOException e) {
>       LOG.warn("Unable to update diagnostics in state store for "
>           + containerId, e);
>     }
>   }
> {code} 
> So we don't need call {{storeContainerDiagnostics}} in  ContainerDiagnosticsUpdateTransition#transition.
> {code}
>       container.addDiagnostics(updateEvent.getDiagnosticsUpdate(), "\n");
>       try {
>         container.stateStore.storeContainerDiagnostics(container.containerId,
>             container.diagnostics);
>       } catch (IOException e) {
>         LOG.warn("Unable to update state store diagnostics for "
>             + container.containerId, e);
>       }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)