Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0D3F21738B for ; Tue, 12 May 2015 12:17:07 +0000 (UTC) Received: (qmail 87015 invoked by uid 500); 12 May 2015 12:17:06 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 86974 invoked by uid 500); 12 May 2015 12:17:06 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 86962 invoked by uid 99); 12 May 2015 12:17:06 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 May 2015 12:17:06 +0000 Date: Tue, 12 May 2015 12:17:06 +0000 (UTC) From: "Hudson (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-3587) Fix the javadoc of DelegationTokenSecretManager in projects of yarn, etc. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539740#comment-14539740 ] Hudson commented on YARN-3587: ------------------------------ FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #194 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/194/]) YARN-3587. Fix the javadoc of DelegationTokenSecretManager in yarn, etc. projects. Contributed by Gabor Liptak. (junping_du: rev 7e543c27fa2881aa65967be384a6203bd5b2304f) * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/JHSDelegationTokenSecretManager.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/security/TimelineDelegationTokenSecretManagerService.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/security/token/delegation/DelegationTokenSecretManager.java * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/security/token/delegation/DelegationTokenSecretManager.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/security/RMDelegationTokenSecretManager.java > Fix the javadoc of DelegationTokenSecretManager in projects of yarn, etc. > ------------------------------------------------------------------------- > > Key: YARN-3587 > URL: https://issues.apache.org/jira/browse/YARN-3587 > Project: Hadoop YARN > Issue Type: Bug > Components: documentation > Affects Versions: 2.7.0 > Reporter: Akira AJISAKA > Assignee: Gabor Liptak > Priority: Minor > Labels: newbie > Fix For: 2.8.0 > > Attachments: YARN-3587.1.patch, YARN-3587.patch > > > In RMDelegationTokenSecretManager and TimelineDelegationTokenSecretManager, the javadoc of the constructor is as follows: > {code} > /** > * Create a secret manager > * @param delegationKeyUpdateInterval the number of seconds for rolling new > * secret keys. > * @param delegationTokenMaxLifetime the maximum lifetime of the delegation > * tokens > * @param delegationTokenRenewInterval how often the tokens must be renewed > * @param delegationTokenRemoverScanInterval how often the tokens are scanned > * for expired tokens > */ > {code} > 1. "the number of seconds" should be "the number of milliseconds". > 2. It's better to add time unit to the description of other parameters. -- This message was sent by Atlassian JIRA (v6.3.4#6332)