Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Thu, 7 May 2015 21:55:00 +0000 (UTC)
From: "Gabor Liptak (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12827780.1430940121000.41233.1431035700432@Atlassian.JIRA>
In-Reply-To: <JIRA.12827780.1430940121000@Atlassian.JIRA>
References: <JIRA.12827780.1430940121000@Atlassian.JIRA>
 <JIRA.12827780.1430940121633@arcas>
Subject: [jira] [Commented] (YARN-3587) Fix the javadoc of
 DelegationTokenSecretManager in yarn project
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533456#comment-14533456 ] 

Gabor Liptak commented on YARN-3587:
------------------------------------

[~ajisakaa] Done (I hope correctly ...)


> Fix the javadoc of DelegationTokenSecretManager in yarn project
> ---------------------------------------------------------------
>
>                 Key: YARN-3587
>                 URL: https://issues.apache.org/jira/browse/YARN-3587
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: 2.7.0
>            Reporter: Akira AJISAKA
>            Assignee: Gabor Liptak
>            Priority: Minor
>              Labels: newbie
>
> In RMDelegationTokenSecretManager and TimelineDelegationTokenSecretManager,  the javadoc of the constructor is as follows:
> {code}
>   /**
>    * Create a secret manager
>    * @param delegationKeyUpdateInterval the number of seconds for rolling new
>    *        secret keys.
>    * @param delegationTokenMaxLifetime the maximum lifetime of the delegation
>    *        tokens
>    * @param delegationTokenRenewInterval how often the tokens must be renewed
>    * @param delegationTokenRemoverScanInterval how often the tokens are scanned
>    *        for expired tokens
>    */
> {code}
> 1. "the number of seconds" should be "the number of milliseconds".
> 2. It's better to add time unit to the description of other parameters.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)