Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1A32318A5E for ; Thu, 7 May 2015 00:12:00 +0000 (UTC) Received: (qmail 96226 invoked by uid 500); 7 May 2015 00:12:00 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 96186 invoked by uid 500); 7 May 2015 00:11:59 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 96174 invoked by uid 99); 7 May 2015 00:11:59 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 May 2015 00:11:59 +0000 Date: Thu, 7 May 2015 00:11:59 +0000 (UTC) From: "Gabor Liptak (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (YARN-3587) Fix the javadoc of DelegationTokenSecretManager in yarn project MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Liptak updated YARN-3587: ------------------------------- Attachment: YARN-3587.patch > Fix the javadoc of DelegationTokenSecretManager in yarn project > --------------------------------------------------------------- > > Key: YARN-3587 > URL: https://issues.apache.org/jira/browse/YARN-3587 > Project: Hadoop YARN > Issue Type: Bug > Components: documentation > Affects Versions: 2.7.0 > Reporter: Akira AJISAKA > Priority: Minor > Labels: newbie > Attachments: YARN-3587.patch > > > In RMDelegationTokenSecretManager and TimelineDelegationTokenSecretManager, the javadoc of the constructor is as follows: > {code} > /** > * Create a secret manager > * @param delegationKeyUpdateInterval the number of seconds for rolling new > * secret keys. > * @param delegationTokenMaxLifetime the maximum lifetime of the delegation > * tokens > * @param delegationTokenRenewInterval how often the tokens must be renewed > * @param delegationTokenRemoverScanInterval how often the tokens are scanned > * for expired tokens > */ > {code} > 1. "the number of seconds" should be "the number of milliseconds". > 2. It's better to add time unit to the description of other parameters. -- This message was sent by Atlassian JIRA (v6.3.4#6332)