Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EBCBD10268 for ; Tue, 5 May 2015 13:56:00 +0000 (UTC) Received: (qmail 40222 invoked by uid 500); 5 May 2015 13:56:00 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 40173 invoked by uid 500); 5 May 2015 13:56:00 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 40160 invoked by uid 99); 5 May 2015 13:56:00 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 May 2015 13:56:00 +0000 Date: Tue, 5 May 2015 13:56:00 +0000 (UTC) From: "Junping Du (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-3523) Cleanup ResourceManagerAdministrationProtocol interface audience MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-3523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14528459#comment-14528459 ] Junping Du commented on YARN-3523: ---------------------------------- Latest patch LGTM. However, I think we don't need @Private for every method because we already specified it in class level. In most cases, we need some different visibility in method level is to override the class level. [~vinodkv], what do you think? > Cleanup ResourceManagerAdministrationProtocol interface audience > ---------------------------------------------------------------- > > Key: YARN-3523 > URL: https://issues.apache.org/jira/browse/YARN-3523 > Project: Hadoop YARN > Issue Type: Bug > Components: client, resourcemanager > Reporter: Wangda Tan > Assignee: Naganarasimha G R > Labels: newbie > Attachments: YARN-3523.20150422-1.patch, YARN-3523.20150504-1.patch, YARN-3523.20150505-1.patch > > > I noticed ResourceManagerAdministrationProtocol has @Private audience for the class and @Public audience for methods. It doesn't make sense to me. We should make class audience and methods audience consistent. -- This message was sent by Atlassian JIRA (v6.3.4#6332)