Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5401610042 for ; Thu, 7 May 2015 03:50:05 +0000 (UTC) Received: (qmail 28930 invoked by uid 500); 7 May 2015 03:50:00 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 28883 invoked by uid 500); 7 May 2015 03:50:00 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 28872 invoked by uid 99); 7 May 2015 03:50:00 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 May 2015 03:50:00 +0000 Date: Thu, 7 May 2015 03:50:00 +0000 (UTC) From: "Li Lu (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-3513) Remove unused variables in ContainersMonitorImpl MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14531946#comment-14531946 ] Li Lu commented on YARN-3513: ----------------------------- bq. my intention was to actually capture the total usage when the monitors ran, so that it includes the usage of containers which are about to be killled as part of monitor's run. OK, that sounds reasonable to me, but I'd certainly appreciate if any committers can help verify this. > Remove unused variables in ContainersMonitorImpl > ------------------------------------------------ > > Key: YARN-3513 > URL: https://issues.apache.org/jira/browse/YARN-3513 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager > Reporter: Naganarasimha G R > Assignee: Naganarasimha G R > Priority: Trivial > Labels: BB2015-05-TBR, newbie > Attachments: YARN-3513.20150421-1.patch, YARN-3513.20150503-1.patch, YARN-3513.20150506-1.patch > > > class members : {{private final Context context;}} > and some local variables in MonitoringThread.run() : {{vmemStillInUsage and pmemStillInUsage}} are not used and just updated. -- This message was sent by Atlassian JIRA (v6.3.4#6332)