Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3D67817F9C for ; Thu, 7 May 2015 21:55:01 +0000 (UTC) Received: (qmail 19904 invoked by uid 500); 7 May 2015 21:55:01 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 19866 invoked by uid 500); 7 May 2015 21:55:01 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 19854 invoked by uid 99); 7 May 2015 21:55:01 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 May 2015 21:55:01 +0000 Date: Thu, 7 May 2015 21:55:00 +0000 (UTC) From: "Li Lu (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-1832) wrong MockLocalizerStatus.equals() method implementation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-1832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533457#comment-14533457 ] Li Lu commented on YARN-1832: ----------------------------- This patch still applies to the latest trunk (as of now). LGTM. > wrong MockLocalizerStatus.equals() method implementation > -------------------------------------------------------- > > Key: YARN-1832 > URL: https://issues.apache.org/jira/browse/YARN-1832 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager > Affects Versions: 2.2.0 > Reporter: Hong Zhiguo > Assignee: Hong Zhiguo > Priority: Trivial > Labels: BB2015-05-TBR > Attachments: YARN-1832.patch > > > "return getLocalizerId().equals(other) && ...;" should be > "return getLocalizerId().equals(other. getLocalizerId()) && ...;" > getLocalizerId() returns String. It's expected to compare this.getLocalizerId() against other.getLocalizerId(). -- This message was sent by Atlassian JIRA (v6.3.4#6332)