hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3732) Change NodeHeartbeatResponse.java and RegisterNodeManagerResponse.java as abstract classes
Date Thu, 28 May 2015 10:54:17 GMT

    [ https://issues.apache.org/jira/browse/YARN-3732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14562681#comment-14562681
] 

Hadoop QA commented on YARN-3732:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  14m 59s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags.
|
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear to include any
new or modified tests.  Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | javac |   8m  4s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 50s | There were no new javadoc warning messages.
|
| {color:green}+1{color} | release audit |   0m 23s | The applied patch does not increase
the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   0m 33s | There were no new checkstyle issues. |
| {color:red}-1{color} | whitespace |   0m  1s | The patch has 2  line(s) that end in whitespace.
Use git apply --whitespace=fix. |
| {color:green}+1{color} | install |   1m 35s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 32s | The patch built with eclipse:eclipse.
|
| {color:green}+1{color} | findbugs |   0m 52s | The patch does not introduce any new Findbugs
(version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests |   0m 25s | Tests passed in hadoop-yarn-server-common.
|
| | |  37m 18s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12735838/YARN-3732.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 7e509f5 |
| whitespace | https://builds.apache.org/job/PreCommit-YARN-Build/8112/artifact/patchprocess/whitespace.txt
|
| hadoop-yarn-server-common test log | https://builds.apache.org/job/PreCommit-YARN-Build/8112/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/8112/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/8112/console |


This message was automatically generated.

> Change NodeHeartbeatResponse.java and RegisterNodeManagerResponse.java as abstract classes
> ------------------------------------------------------------------------------------------
>
>                 Key: YARN-3732
>                 URL: https://issues.apache.org/jira/browse/YARN-3732
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Devaraj K
>            Assignee: Devaraj K
>            Priority: Minor
>         Attachments: YARN-3732.patch
>
>
> All the other protocol record classes are abstract classes. Change NodeHeartbeatResponse.java
and RegisterNodeManagerResponse.java as abstract classes to make it consistent with other
protocol record classes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message