hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vrushali C (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (YARN-3696) Make the review suggestions from YARN-3411 patch
Date Thu, 21 May 2015 18:58:17 GMT

     [ https://issues.apache.org/jira/browse/YARN-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Vrushali C updated YARN-3696:
-----------------------------
    Description: 
As per the review suggestions from [~djp], [~sjlee0], [~gtCarrera9] , [~jrottinghuis] in YARN-3411,
filing jira to track:

- return of null vs 0 for certain fields in getValueAsLong. 
- remove the constructor with config param from HBaseTimelineWriterImpl
- move the entity creation steps of TestHBaseTimelineWriterImpl to TestTimelineWriterImpl.
In this way we can improve test coverage for both writer implementations after this work.
- make the structure of EntityColumnFamilyDetails more generic (this may need a new jira depending
on the extent of changes, perhaps with unit tests etc). 
- other review suggestions from Joep are being tracked in YARN-3649 Allow configurable prefix
for hbase table names (like prod, exp, test etc) and YARN-3650 Consider concurrency situations
for TimelineWriter

Note: This may not be relevant if the native HBase is not chosen while going ahead.


  was:
As per the review suggestions from [~djp], [~sjlee0], [~gtCarrera9]  in YARN-3411, filing
jira to track:

- return of null vs 0 for certain fields in getValueAsLong. 
- remove the constructor with config param from HBaseTimelineWriterImpl
- 


Note: This may not be relevant if the native HBase is not chosen while going ahead.




> Make the review suggestions from YARN-3411 patch
> ------------------------------------------------
>
>                 Key: YARN-3696
>                 URL: https://issues.apache.org/jira/browse/YARN-3696
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Vrushali C
>            Assignee: Vrushali C
>
> As per the review suggestions from [~djp], [~sjlee0], [~gtCarrera9] , [~jrottinghuis]
in YARN-3411, filing jira to track:
> - return of null vs 0 for certain fields in getValueAsLong. 
> - remove the constructor with config param from HBaseTimelineWriterImpl
> - move the entity creation steps of TestHBaseTimelineWriterImpl to TestTimelineWriterImpl.
In this way we can improve test coverage for both writer implementations after this work.
> - make the structure of EntityColumnFamilyDetails more generic (this may need a new jira
depending on the extent of changes, perhaps with unit tests etc). 
> - other review suggestions from Joep are being tracked in YARN-3649 Allow configurable
prefix for hbase table names (like prod, exp, test etc) and YARN-3650 Consider concurrency
situations for TimelineWriter
> Note: This may not be relevant if the native HBase is not chosen while going ahead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message