hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3682) Decouple PID-file management from ContainerExecutor
Date Wed, 27 May 2015 04:01:18 GMT

    [ https://issues.apache.org/jira/browse/YARN-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14560369#comment-14560369
] 

Hadoop QA commented on YARN-3682:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | patch |   0m  1s | The patch file was not named according to hadoop's
naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions.
|
| {color:blue}0{color} | pre-patch |  14m 51s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags.
|
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to include 6 new
or modified test files. |
| {color:green}+1{color} | javac |   7m 33s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 33s | There were no new javadoc warning messages.
|
| {color:red}-1{color} | release audit |   0m 19s | The applied patch generated 1 release
audit warnings. |
| {color:red}-1{color} | checkstyle |   0m 46s | The applied patch generated  7 new checkstyle
issues (total was 295, now 298). |
| {color:green}+1{color} | whitespace |   0m  2s | The patch has no lines that end in whitespace.
|
| {color:green}+1{color} | install |   1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with eclipse:eclipse.
|
| {color:green}+1{color} | findbugs |   1m  2s | The patch does not introduce any new Findbugs
(version 3.0.0) warnings. |
| {color:red}-1{color} | yarn tests |   6m  2s | Tests failed in hadoop-yarn-server-nodemanager.
|
| | |  42m 19s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.yarn.server.nodemanager.TestContainerManagerWithLCE |
|   | hadoop.yarn.server.nodemanager.containermanager.container.TestContainer |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12735508/YARN-3682-20150526.1.txt
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / cdbd66b |
| Release Audit | https://builds.apache.org/job/PreCommit-YARN-Build/8096/artifact/patchprocess/patchReleaseAuditProblems.txt
|
| checkstyle |  https://builds.apache.org/job/PreCommit-YARN-Build/8096/artifact/patchprocess/diffcheckstylehadoop-yarn-server-nodemanager.txt
|
| hadoop-yarn-server-nodemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/8096/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/8096/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/8096/console |


This message was automatically generated.

> Decouple PID-file management from ContainerExecutor
> ---------------------------------------------------
>
>                 Key: YARN-3682
>                 URL: https://issues.apache.org/jira/browse/YARN-3682
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Vinod Kumar Vavilapalli
>         Attachments: YARN-3682-20150526.1.txt, YARN-3682-20150526.txt
>
>
> The PID-files management currently present in ContainerExecutor really doesn't belong
there. I know the original history of why we added it, that was about the only right place
to put it in at that point of time.
> Given the evolution of executors for Windows etc, the ContainerExecutor is getting more
complicated than is necessary.
> We should pull the PID-file management into its own entity.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message